This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Catch BrokenPipeError from metrics server, and log as a warning #14072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wtf---why is the debian package test run now failing with |
DMRobertson
force-pushed
the
dmr/catch-metric-pipe-errors
branch
from
8cf89cf to
3f13fe8
Compare
squahtx
reviewed
Oct 7, 2022
Comment on lines
+229
to
+232
| except BrokenPipeError as e: | ||
| logger.warning( | ||
| "BrokenPipeError when serving metrics (%s). Did Prometheus restart?", e | ||
| ) |
There was a problem hiding this comment.
I think a warning is the right logging level to use here.
But do we know what's causing the socket to close before we send the response on matrix.org?
There was a problem hiding this comment.
I would guess the prometheus scraper is occasionally restarted? Pure speculation though.
squahtx
approved these changes
Oct 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14066, I think?